Skip to content

Arch Forum 2024-10-31

Participants: Backend devs, Andy, JD, Magnus Victor and Zak

Agenda

  • Followup Retro
  • SQL (Shakib)
  • Refund in hydra (Additional item brought by Gowtham)

Notes

Followup Retro

A short update on the "retro" in the previous Arch Forum of the top 3 issues identified:

  • The top-voted issue, "Remove API layer from Moneyflow/Risk, remove separate auth for those services. This is when Majority-internal services call MF/Risk API layer (instead of Service layer like we normally do)" is now tracked in https://majority.atlassian.net/browse/MIB-11793, and Martin is working on implementing this for Risk Decisions.
  • "Being able to deploy to stage from branches. The main issue is that devs want to test before PR is merged." Victor will try and collect actual cases when this would have been useful to better understand the issue and possible fixes.
  • "Testing (esp Regr testing) breaks easily and is flaky, making deploys less easy" Given we already have focus on improving tests for now no additional focus will be put on testing.

SQL Unit Test (Shakib)

Shakib had a presentation of tSQLt, a library and method to unit test the DB, fully contained within the DB that he learned about from a conference. Presentation here: TSQLT
Its for sure a cool tech, but no decision on if we should use it was made.

Refund in hydra (Additional item brought by Gowtham)

Lastly Gowtham brought up a case about how a Refund button can work in Hydra, call Remittance or the general Transactions service? JD noted that Rapha has already done extensive investigation into this, and that this topic is very complicated once you look deeper. The PMs need to sync.