Skip to content

Arch Forum 2024-10-17

Participants: Andy, Backend devs, Magnus, Zak and Victor

Agenda

  • Configurations in each area?
  • Move Domain.Contracts to each area?
  • DB SP Migrations follow-up

Notes

Configurations in each area?

Platform team is consolidating over all the things to use ArgoCD for deployment, so not only the containers, but also configuration and other supplementary parts. One idea is to move area-specific configuration files back to the repository of the respective area.

Some notes:
- If configuration were moved, the pipeline would need optimizations so that when a prod config is changed not everything else in the pipeline is run, only the ArgoCD deploy step.
- An upside of the current way of doing things is when you need to update both area specific and common configs, like you often need when setting up a new area. If configs are spread out, multiple PR needs to be created.
- Currently the complete configuration/setup of an area is very spread out between repos (at least bank-deployments, bank-configuration, bank-, bank-localization, bank-azure-infrastructure). It would be nice if it was more consolidated.

As for the change itself there was no consensus as to if it's useful or not. In theory its good to have everything related to an area in one place, but in practice it's not clear.

Finally, Gowtham also noted that it would be great if you could dynamically override a config when running a specific test, to for example test with a feature flag both on and off. (Now listed in the Backend Thoughts (Roman) document).

Move Domain.Contracts to each area?

In the bank-core-platform repo we have a number of "Domain" contracts, like Minority.User.Domain.Contract which contains contracts that are part of an area, but cant be in the normal area Contracts because of circular dependencies, typically because the contents are used all over everywhere. The question is, why do we have them in core platform and not in each area? (Note, they would still need to be separate csproj/nugets even if they are located in each area). No objections or real downsides to move them to the respective area were raised in the meeting. Therefore we should move the domain contracts out of core platform.

DB SP Migrations follow-up

Zak asked to clarify the state of the updated DB SP Migrations improvements discussed in Arch Forum 2024-10-03:

A couple of areas (4-5) have been migrated by Rasmus, Lars and Gertian to the new way of handling updates to stored procedures. No issues or downsides found, it works great. Everyone is encouraged to migrate areas whenever they have a little time and it fits with the task, such as when updating stored procedures. If anything is unclear, don't be afraid to ask for help! Sometime in November or December, we will follow-up again and see how much is done vs what's left and if a more directed effort is needed to get everything over to the new way.