Skip to content

Arch Forum 2023-02-23

Notes

The focus was on Johan Hs reflections of our code and system, as this was his last meeting before his contract ends.

  • In general the impression is that everything follows the same pattern, with a comprehensive base library (the platform/infra code). This makes it easy to move around as you recognize the patterns used etc.
  • There are, as in most code bases, "interesting" pieces of code here and there, and Johan showed some examples.
  • The build & release pipeline setup used by Risk is special and make it easy for mistakes and confusion.
  • The biggest room for improvement in Risk is around the tests, which are very slow to run slowing down development.

We also discussed a couple of minor topics:
- Thani asked about the User area db, which has more than 1m users, but around 1/3rd is active. Is this a problem, should we remove/archive them? In general we did not think this should be a problem, Johan H had an example from a different company with more than 300m users in a table.

  • Thani also brought up the case that many services listen to user events and keep a user table. It would be nice if this code somehow could be shared between the services. However, this is not so easy to do since they all store slightly different user data.
  • Liangxiong had a comment about how it can be diffiuclt to know what enums stored as ints in the database mean, since you have to look it up in the code. As a suggestion its best if there is a companion table with all the enum int values and their names, that you can join with while working in the database.